Simplify two colorbar tests and remove all others #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
weiji14
reviewed
Jan 10, 2024
pygmt/tests/test_colorbar.py
Outdated
Comment on lines
60
to
67
| @pytest.mark.mpl_image_compare | ||
| def test_colorbar_shading_list(): | ||
| """ | ||
| Create colorbar and set shading by passing the high/low values as a list. | ||
| """ | ||
| fig = Figure() | ||
| fig.basemap(region=[0, 10, 0, 10], projection="X15c", frame="a") | ||
| fig.colorbar(cmap="geo", shading=[-0.7, 0.2], frame=True) |
There was a problem hiding this comment.
OK, added it back but changed the projection to X8c to have a smaller image size.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified images
Report last updated at commit c35e2d7 |
michaelgrund
approved these changes
Jan 10, 2024
michaelgrund
added
the
final review call
weiji14
approved these changes
Jan 11, 2024
seisman
changed the title
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2961 (comment) for context.
This PR removes all existing colorbar tests and add a new, simpler one.